Opened 5 years ago

Last modified 4 years ago

#1586 reviewing change

Fix doxygen comment for documentUrls in FilterEngine::Matches

Reported by: fhd Assignee: Mailkov
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://github.com/adblockplus/libadblockplus/pull/4

Description

Background

The comment for FilterEngine::Matches currently says the following about documentUrls: "Chain of documents requesting the resource, starting with the current resource's parent frame, ending with the top-level frame.". That's the wrong way around.

What to change

The comment should say: "Chain of documents requesting the resource, starting with the top-level frame, ending with the current resource's parent frame.

Change History (4)

comment:1 Changed 4 years ago by Mailkov

I'd like to work on this!

comment:3 Changed 4 years ago by fhd

  • Owner set to Mailkov
  • Tester set to Unknown

comment:4 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.