Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#1588 closed change (fixed)

Integrate ensure_dependencies.py with the adblockplus repository

Reported by: poz2k4444 Assignee: poz2k4444
Priority: P4 Milestone: Adblock-Plus-2.6.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, matze, fhd Blocked By: #170, #1364, #1777
Blocking: #1757 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6018170477346816/

Description (last modified by trev)

Background

In #170 we introduced our custom dependency mechanism, it should be used by the adblockplus repository.

What to change

  • Add the ensure_dependencies.py script to the root of the adblockpluschrome repository.
  • Migrate the contents of the .hgsub and .hgsubstate files to a dependencies file for use by the ensure_dependencies.py script. (See ticket #170 and the script itself for more information about the format. See the infrastructure repository for a working example.)
  • Update build.py to execute the ensure_dependencies.py script as a subprocess before running tasks

Hints for testers

Nothing to test here. This change merely affects build tools, it was verified that the build produced after the change is identical to the old one.

Change History (10)

comment:1 Changed 5 years ago by matze

  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed 5 years ago by matze

  • Owner set to poz2k4444

comment:3 Changed 5 years ago by trev

  • Blocked By 170, 1364 added
  • Component changed from Infrastructure to Adblock-Plus-for-Firefox
  • Description modified (diff)

comment:4 Changed 5 years ago by poz2k4444

  • Review URL(s) modified (diff)

comment:5 Changed 5 years ago by poz2k4444

  • Blocking 1757 added

comment:6 Changed 5 years ago by poz2k4444

  • Description modified (diff)

comment:7 Changed 5 years ago by trev

  • Blocked By 1777 added

comment:8 Changed 5 years ago by trev

  • Status changed from new to reviewing

comment:9 Changed 5 years ago by trev

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Firefox-next
  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.