Opened on 11/20/2014 at 02:18:53 PM

Closed on 01/13/2015 at 04:56:47 PM

Last modified on 05/20/2015 at 02:22:39 PM

#1588 closed change (fixed)

Integrate with the adblockplus repository

Reported by: poz2k4444 Assignee: poz2k4444
Priority: P4 Milestone: Adblock-Plus-2.6.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, matze, fhd Blocked By: #170, #1364, #1777
Blocking: #1757 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by trev)


In #170 we introduced our custom dependency mechanism, it should be used by the adblockplus repository.

What to change

  • Add the script to the root of the adblockpluschrome repository.
  • Migrate the contents of the .hgsub and .hgsubstate files to a dependencies file for use by the script. (See ticket #170 and the script itself for more information about the format. See the infrastructure repository for a working example.)
  • Update to execute the script as a subprocess before running tasks

Hints for testers

Nothing to test here. This change merely affects build tools, it was verified that the build produced after the change is identical to the old one.

Attachments (0)

Change History (10)

comment:1 Changed on 11/20/2014 at 03:08:43 PM by matze

  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed on 11/20/2014 at 03:09:08 PM by matze

  • Owner set to poz2k4444

comment:3 Changed on 11/20/2014 at 03:13:58 PM by trev

  • Blocked By 170, 1364 added
  • Component changed from Infrastructure to Adblock-Plus-for-Firefox
  • Description modified (diff)

comment:4 Changed on 11/21/2014 at 03:15:11 PM by poz2k4444

  • Review URL(s) modified (diff)

comment:5 Changed on 01/06/2015 at 03:10:55 PM by poz2k4444

  • Blocking 1757 added

comment:6 Changed on 01/06/2015 at 04:00:02 PM by poz2k4444

  • Description modified (diff)

comment:7 Changed on 01/11/2015 at 11:04:27 PM by trev

  • Blocked By 1777 added

comment:8 Changed on 01/13/2015 at 04:26:29 PM by trev

  • Status changed from new to reviewing

comment:9 Changed on 01/13/2015 at 04:56:47 PM by trev

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Firefox-next
  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from poz2k4444.
Note: See TracTickets for help on using tickets.