Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#1596 closed defect (fixed)

Improper behavior when tried to Disable ABP for invalid pages.

Reported by: passbrains Assignee: Mailkov
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr, sergz Blocked By:
Blocking: #3428 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Rraceanu Verified working: yes
Review URL(s):

https://github.com/adblockplus/adblockplusie/pull/11
https://codereview.adblockplus.org/29332455/

Description (last modified by oleksandr)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AIN-69

Environment

Windows + 7 64bit + Internet Explorer 10 + English
ABP version 1.2.705.0

How to reproduce

Launch IE with ABP enabled.
Check the manage dialog on settings page.
On IE, click on new tab button to add another tab.Make sure new tab opens with by default page as 'about:blank'.
On the about:blank page, click on ABP icon and select option 'Disable on about:blank'.
Check the ABP icon, 'Disable on about:blank' button status and check manage dialog on settings page.

Observed behaviour

After selecting 'Disable on about:blank' button,
1.ABP icon does not get disabled and also looks distorted.

  1. 'Disable on about:blank' button does not get checked(enabled)

3.about:blank page get added in manage dialog on settings page.
[See attached video]

Expected behaviour

There should be consistency in behavior when user try to disable invalid pages.
1)Either Disable option should not work and page should not get added in manage dialog.
2)OR If it should work for any link, then ABP button and Disable option status should change accordingly. 

Attachments (1)

4816_1411478892_Invalid_pages.mp4 (302.6 KB) - added by passbrains 5 years ago.

Download all attachments as: .zip

Change History (16)

Changed 5 years ago by passbrains

comment:1 Changed 5 years ago by oleksandr

  • Cc oleksandr added
  • Component changed from Unknown to Adblock-Plus-for-Internet-Explorer
  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 5 years ago by oleksandr

  • Priority changed from P3 to P4

comment:3 Changed 5 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.4

comment:4 Changed 5 years ago by Mailkov

I'd like to work on this.

comment:6 Changed 4 years ago by Mailkov

Can you assign it to me? So I will receive e-mail on this issue.

comment:7 Changed 4 years ago by oleksandr

  • Owner set to Mailkov

comment:8 Changed 4 years ago by Mailkov

I have updated the pull request ... now the menuitem is hidden.

comment:9 Changed 4 years ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Tester set to Unknown

comment:10 Changed 4 years ago by sergz

  • Cc sergz added

comment:11 Changed 4 years ago by eric@…

  • Blocking 3428 added

comment:12 Changed 4 years ago by eric@…

  • Review URL(s) modified (diff)

comment:13 Changed 4 years ago by eric@…

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:14 Changed 3 years ago by rraceanu

  • Tester changed from Unknown to Rraceanu

comment:15 Changed 3 years ago by rraceanu

  • Verified working set

Fixed implemented successfully ABP for IE 1.5.856, verified on Win 7, Win 8 and Win 10 IE 9 and 11. Text is greyed out and not functional when trying to add "invalid" pages as an exception.

Version 0, edited 3 years ago by rraceanu (next)
Note: See TracTickets for help on using tickets.