Opened 5 years ago

Closed 5 years ago

#1601 closed defect (fixed)

"Block element" does not generate blocking filters for elements with multiple URLs

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5468762555809792

Description

How to reproduce

  1. Go to http://www.webkit.org/demos/srcset/ or http://www.w3schools.com/html/html5_video.asp
  2. Click the ABP icon
  3. Choose "Block element"
  4. Click the sample image or video respectively

Observed behaviour

The dialog shows up, but it neither generates blocking filters for the video's URLs (configured with <source> child elements), nor for the alternative sizes (configured by the srcset attribute) of the image.

Expected behaviour

Blocking filters for all URLs associated with selected element should be generated.

Change History (2)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.