Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#1602 closed change (fixed)

Use ES6 generators instead of legacy generators

Reported by: tschuster Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: tschuster, sebastian Blocked By: #2235
Blocking: #312, #2231 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6612223174639616
http://codereview.adblockplus.org/5706475775197184
http://codereview.adblockplus.org/5738402414592000

Description (last modified by sebastian)

Background

Our code currently uses the legacy generator functions:

function foo()
{
  yield "bar";
}

This syntax is deprecated.

What to change

Use the new syntax:

function* foo()
{
  yield "bar";
}

This is supported starting with Firefox 29, so we'll have to change compatibility info.

Note that JSHydra will have to be updated as well to support this syntax.

Change History (16)

comment:1 Changed 5 years ago by tschuster

  • Owner set to tschuster

comment:2 Changed 5 years ago by trev

  • Description modified (diff)
  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Priority changed from Unknown to P4
  • Ready set
  • Type changed from defect to change

comment:3 Changed 5 years ago by trev

  • Owner tschuster deleted

comment:4 Changed 5 years ago by trev

  • Cc tschuster added

comment:5 Changed 5 years ago by sebastian

  • Blocking 2231 added

comment:6 Changed 5 years ago by sebastian

  • Cc sebastian added

comment:7 Changed 5 years ago by trev

  • Blocked By 2235 added

comment:8 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:9 Changed 5 years ago by sebastian

  • Owner set to sebastian

comment:10 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:11 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)

comment:14 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)

comment:16 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.