Opened on 11/24/2014 at 04:11:24 PM

Closed on 04/01/2015 at 08:42:10 AM

Last modified on 05/20/2015 at 02:22:39 PM

#1602 closed change (fixed)

Use ES6 generators instead of legacy generators

Reported by: tschuster Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: tschuster, sebastian Blocked By: #2235
Blocking: #312, #2231 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by sebastian)


Our code currently uses the legacy generator functions:

function foo()
  yield "bar";

This syntax is deprecated.

What to change

Use the new syntax:

function* foo()
  yield "bar";

This is supported starting with Firefox 29, so we'll have to change compatibility info.

Note that JSHydra will have to be updated as well to support this syntax.

Attachments (0)

Change History (16)

comment:1 Changed on 11/24/2014 at 04:11:39 PM by tschuster

  • Owner set to tschuster

comment:2 Changed on 03/30/2015 at 01:33:11 PM by trev

  • Description modified (diff)
  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Priority changed from Unknown to P4
  • Ready set
  • Type changed from defect to change

comment:3 Changed on 03/30/2015 at 01:33:59 PM by trev

  • Owner tschuster deleted

comment:4 Changed on 03/30/2015 at 01:34:15 PM by trev

  • Cc tschuster added

comment:5 Changed on 03/30/2015 at 01:34:23 PM by sebastian

  • Blocking 2231 added

comment:6 Changed on 03/30/2015 at 01:34:57 PM by sebastian

  • Cc sebastian added

comment:7 Changed on 03/30/2015 at 01:56:46 PM by trev

  • Blocked By 2235 added

comment:8 Changed on 03/31/2015 at 02:07:53 PM by sebastian

  • Description modified (diff)

comment:9 Changed on 03/31/2015 at 05:34:26 PM by sebastian

  • Owner set to sebastian

comment:10 Changed on 03/31/2015 at 05:45:35 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:11 Changed on 04/01/2015 at 08:42:10 AM by sebastian

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed on 04/01/2015 at 09:41:14 AM by sebastian

  • Review URL(s) modified (diff)

comment:13 Changed on 04/01/2015 at 09:45:28 AM by sebastian

comment:14 Changed on 04/02/2015 at 05:04:03 PM by sebastian

  • Review URL(s) modified (diff)

comment:15 Changed on 04/16/2015 at 10:14:34 AM by sebastian

comment:16 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Note: See TracTickets for help on using tickets.