Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1606 closed defect (fixed)

"Block element" injects overlays for hidden elements

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6463903206735872

Description

How to reproduce

  1. Go to http://www.w3schools.com/html/html5_video.asp
  2. Click ABP icon
  3. Choose "Block element"

Observed behaviour

You see a couple of overlays placed in the upper left corner. Those overlays have been created for hidden elements (style="display: none;"). Hence the content covered by those overlays don't match the elements they were created for.

Expected behaviour

No overlays should be created for hidden elements.

Change History (5)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 5 years ago by sebastian

Also see #1124

comment:5 Changed 5 years ago by sebastian

Also see #1394

Note: See TracTickets for help on using tickets.