Opened 2 years ago

Last modified 12 months ago

#1608 reviewing change

Introduce SCM module in Puppet

Reported by: matze Assignee: matze
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: fhd, fred, trev Blocked By:
Blocking: #3663 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

(As discussed with @trev and @fhd on IRC:) We have a few dozen exec {... } based invocations of hg(1) in our infrastructure repository, and almost as many different versions when looking at the details. This should become abstracted in order to not repeat ourselves and to remove unnecessary possible failure sources.

Goal

Introduce a Puppet module that abstracts the invocations and replace the aforementioned exec {... } directives accordingly.

Notes

There's probably plenty of similar modules out there already, so we may not need to write a new one from scratch. Still, since it's a relatively trivial domain, we may not want to introduce another explicit dependency for this. Especially since we may want to also integrate the ensure_dependency.py script based on this module, and thus may need to apply more patches to any existing module than an individual solution would require.

Change History (8)

comment:1 Changed 2 years ago by matze

Status: @AAlvz, @poz2k4444 and I have actually already started looking into a set of modules for Puppet yesterday; we've just missed the ticket today and realized there's none yet.

comment:2 Changed 2 years ago by matze

  • Owner changed from AAlvz, poz2k4444 to matze

comment:3 Changed 2 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 years ago by matze

  • Review URL(s) modified (diff)

comment:5 Changed 12 months ago by matze

  • Cc fred added; trev removed
  • Priority changed from P4 to P2
  • Review URL(s) modified (diff)
  • Tester set to Unknown

With our recent plans to use bookmarks as feature branches, i.e. master, we have to address most of the code snippets in question for this ticket here anyway. Hence I do consider the implementation more urgent now, and also include the requirement for post-update trigger support (i.e. python ensure_dependencies.py).

Ideally, the new Puppet module should not only cover Mercurial, but also allow for using the same mechanisms with Git - in order to allow for testing new code without the requirement to clone and mirror it on hg.adblockplus.org or any other HG entities first.

comment:6 Changed 12 months ago by trev

  • Cc trev added

comment:7 Changed 12 months ago by matze

  • Summary changed from Introduce Mercurial module in Puppet to Introduce SCM module in Puppet

comment:8 Changed 12 months ago by matze

  • Blocking 3663 added
Note: See TracTickets for help on using tickets.