Opened 5 years ago

Last modified 5 years ago

#1611 closed defect

Inconsistent behavior with "Block element" context menu item — at Version 1

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6236888415338496

Description

How to reproduce

  1. Go to http://9gag.com/gif
  2. Right-click any video
  3. Choose "Block element"

Observed behaviour

The dialog shows up, but it suggests only one filter (e.g. ||img-9gag-ftw.9cache.com/photo/a9MmnMK_460sv.mp4). But since #1601, when you use "Block element" form the popup UI, also filters for the other URLs associated with that element are generated.

That is because when using the context menu, Adblock Plus relies on the srcUrl provided by the context menu API, instead using the logic to generate filters from a given element.

Expected behaviour

The behavior of "Block Element", when used from the context menu and used via the popup UI should be consistent, always generating filters for all URLs associated with that element.

Change History (1)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.