Opened 5 years ago

Last modified 5 years ago

#1613 closed defect

Elements loaded from non-HTTP URLs are collapsed — at Version 2

Reported by: passbrains Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6646117731139584

Description (last modified by sebastian)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AOP-138

Environment

Windows + Vista 64bit + Opera + English
ABP version Adblock Plus Version 1.8.7.1254

How to reproduce

  1. Install ABP extension on Opera.
  1. Load website

http://adventagegroups.com/Index.aspx

  1. Add *.html  in  "Add your own filters"
  2. Select Block element  from ABP menu and click on "Contact us" as shown in html1.jpg

Observe that all menu items would be selected automatically.
5 Check again the ABP icon options. and click on it.
see image html2.jpg

  1. Check again ABP icon options.

 
.

Observed behaviour

Step 5 : Still the Block element option is present.
Step 6. Cancel option  is present instead of "Block element".

Expected behaviour

Step 5 : Cancel  option shall be present instead of "Block element".
Step 6 : "Block element" option shall be present instead of "Cancel".

Change History (4)

Changed 5 years ago by passbrains

Changed 5 years ago by passbrains

comment:1 Changed 5 years ago by sebastian

  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Owner set to sebastian
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from [Negative Case]Adding *.html in filter breaks the behavior of block element to Elements loaded from non-HTTP URLs are collapsed

Even though we only do request blocking for http:// and https:// URLs, element collapsing is applied for all elements, including the <iframe> showing chrome-extension://../block.html.

comment:2 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.