Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#1619 closed change (rejected)

Wrong return value of CPluginClass::Invoke

Reported by: sergz Assignee: sergz
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By: #1672
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6453924974297088

Description

Background

It should return at least S_OK (see http://msdn.microsoft.com/en-us/library/windows/desktop/ms221479%28v=vs.85%29.aspx) not VARIANT_TRUE.

What to change

Change the return value.

Change History (4)

comment:1 Changed 5 years ago by sergz

  • Status changed from new to reviewing

comment:2 Changed 4 years ago by oleksandr

  • Blocked By 1672 added
  • Platform changed from Unknown to Internet Explorer
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 4 years ago by sergz

  • Resolution set to rejected
  • Status changed from reviewing to closed

After #1672 it's not relevant any more.

comment:4 Changed 3 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next
  • Tester set to Unknown
Note: See TracTickets for help on using tickets.