Opened 5 years ago

Closed 22 months ago

#1620 closed defect (rejected)

Warning: Unresponsive script trying to view large subscriptions in Firefox 37.0a1

Reported by: Gingerbread Man Assignee:
Priority: Unknown Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: mapx, trev Blocked By:
Blocking: Platform: Firefox
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by Gingerbread Man)

Environment

Nightly 37.0a1 (2014-12-05) • Adblock Plus 2.6.6.3878

How to reproduce

  1. Click the Adblock Plus icon and choose Filter Preferences.
  2. Click the Filter Subscriptions tab.
  3. If no filters are shown on the right, right-click any subscription and choose Show/Hide Filters.
  4. Click either the Hits or Slow Filters (!) column header to sort by that criterion.
  5. Click EasyList on the left.

Observed behavior

The browser hangs. After a few moments, the following prompt is displayed:

Warning: Unresponsive script

A script on this page may be busy, or it may have stopped responding. You can stop the script now, open the script in the debugger, or let the script continue.

Script: chrome://adblockplus/content/ui/filters-filterview.js:526

Expected behavior

The filters in the subscription should be displayed instantly and without any error message.

Forum thread

https://adblockplus.org/forum/viewtopic.php?f=1&t=26356

Change History (9)

comment:1 Changed 5 years ago by mapx

comment on forum:

Turns out this is caused by sorting by last hit; by default (unsorted), easylist displays instantly.

Suggestion: "last hit" sorting should be reversed, by default (newest first - Z>A), as this is its main use.

https://adblockplus.org/forum/viewtopic.php?p=112035#p112035

comment:2 Changed 5 years ago by mapx

  • Cc mapx added

comment:3 Changed 5 years ago by Gingerbread Man

  • Description modified (diff)
  • Summary changed from Warning: Unresponsive script trying to view large subscriptions in Firefox 36.0a1 to Warning: Unresponsive script trying to view large subscriptions in Firefox 37.0a1

comment:4 Changed 4 years ago by hurda

Apparently Firefox's e10s-shims are causing this even in non-e10s-mode:
https://adblockplus.org/forum/viewtopic.php?p=121130#p121130

comment:5 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:6 Changed 3 years ago by mapx

  • Cc trev added
  • Tester set to Unknown

comment:7 Changed 3 years ago by mapx

still happens:

  • sort easylist for "enabled" column. Then go to "custom filters" tab.

Go again to "Filter subscriptions" tab ==> it's very very slow. Try to select one other subscription in that page => it's very slow (could be 20-30 seconds) and unresponsive.

To have a normal behaviour you have to choose "sort by unsorted"

Tested with firefox 46, 48, ABP 2.7.3.4173

Last edited 3 years ago by mapx (previous) (diff)

comment:8 Changed 3 years ago by trev

Generally, sorting filter lists can be slow. The extreme slowdowns are usually due to Firefox adding lots of overhead however, probably https://bugzilla.mozilla.org/show_bug.cgi?id=1162392 (https://bugzilla.mozilla.org/show_bug.cgi?id=1153387 no longer affects us).

comment:9 Changed 22 months ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.