Opened 5 years ago

Closed 18 months ago

#1621 closed change (invalid)

Extend "Remove selected" button on

Reported by: sergz Assignee:
Priority: P4 Milestone:
Module: User-Interface Keywords:
Cc: sven, greiner Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

Currently, showing the "Remove selected" button in the options page makes no sense if nothing is selected from the list because in this case clicking on the button doesn't do anything. Therefore we should reflect that in the UI by disabling the button if nothing is selected.

What to change

On the options page's "Add your own filters" and "Whitelisted domains" tabs, disable the "Remove selected" button when no element is selected in the list next to it. Consequently, that means that it should also be disabled if the list is empty.

Change History (4)

comment:1 Changed 5 years ago by sven

We handle this problem by doing it differently in the new options page. You can have a look at it here. Therefore i would suggest to make no changes in the current chrome/safari/opera UI.

comment:2 Changed 5 years ago by greiner

  • Priority changed from Unknown to P4

comment:3 Changed 5 years ago by greiner

  • Description modified (diff)
  • Ready set

Marking it as ready because it appears that the options page redesign will take a while still.

Note that I removed renaming it to "Clear" from the issue description because currently, it doesn't clear the list when nothing is selected.

comment:4 Changed 18 months ago by greiner

  • Cc greiner added
  • Resolution set to invalid
  • Status changed from new to closed
  • Tester set to Unknown

Closing this ticket because we removed the page in question in #6431.

Note: See TracTickets for help on using tickets.