Opened 5 years ago

Closed 22 months ago

#1626 closed defect (rejected)

Placeholder image appears only after refresh

Reported by: passbrains Assignee:
Priority: P5 Milestone:
Module: Platform Keywords:
Cc: greiner, trev, sebastian Blocked By:
Blocking: Platform: Opera
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sebastian)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AOP-123

Environment

Windows + Vista 64bit + Opera + English
ABP version Adblock Plus Version 1.8.7.1253

How to reproduce

  1. Install ABP extension on Opera.
  2. Uncheck the "Hide placeholders of blocked elements" Adblock Plus option. See screenshot hide-placeholder.jpg
  3. Load website http://hiox.com/nov17.php
  4. Block the image 'nov17.jpg' by right click option.

Filter added would be :

hiox.com/images/nov17.jpg
  1. Observation 1 : Observe placeholder image
  2. Refresh the page.
  3. Observation 2 : Observe placeholder image

Observed behaviour

Step 5 - Observation 1 :  Placeholder image does not show-up.
see a screenshot hiox.jpg.
Step 7 - Observation 2 :  Placeholder image shows up.
see a screenshot hiox-onrefresh.jpg.

Expected behaviour

Placeholder image shall appear without refresing the page as soon as target image is blocked.
This happens correctly on other websites.

Attachments (2)

3659_1416068558_hiox.jpg (97.6 KB) - added by passbrains 5 years ago.
3659_1416068558_hiox-onrefresh.jpg (94.2 KB) - added by passbrains 5 years ago.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by passbrains

Changed 5 years ago by passbrains

comment:1 Changed 5 years ago by passbrains

1 - 26 Nov 2014 13:56:05 posted by Thomas Greiner
You mentioned that "This happens correctly on other websites." Could you specify an example site where you think it does work correctly?

comment:2 follow-up: Changed 5 years ago by sebastian

  • Cc greiner trev sebastian added
  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Priority changed from Unknown to P3

The problem here is that the blocked element is removed regardless whether element collapsing is enabled in the options. This is related to #370 and might be solved with the patch that's currently under review there.

Last edited 5 years ago by sebastian (previous) (diff)

comment:3 in reply to: ↑ 2 Changed 5 years ago by greiner

Replying to sebastian:

The problem here is that the blocked element is removed regardless whether element collapsing is enabled in the options. This is related to #370 and might be solved with the patch that's currently under review there.

I doubt that #370 will fix this. This issue is about how we hide something whereas #370 is about which elements we hide.

comment:4 Changed 5 years ago by sebastian

The current version of the patch doesn't remove elements that shouldn't be collapsed anymore. However, it wouldn't touch blocked elements at all, when element collapsing is disabled.

So we might want consider a different approach, like I suggested in the review, which would fix both issues, instead making this issue just worse.

comment:5 Changed 5 years ago by sebastian

  • Priority changed from P3 to P5

We just removed the "Hide placeholders" option from the UI, and might remove that feature all together in the future. However, until then this bug is still valid, though rather unimportant.

comment:6 Changed 22 months ago by sebastian

  • Resolution set to rejected
  • Status changed from new to closed
  • Tester set to Unknown

While Prefs.hidePlaceholders still hasn't been completely removed, it is unlikely that this issue will ever get fixed, and I'd rather avoid adding complexity to improve a deprecated, hidden feature.

Note: See TracTickets for help on using tickets.