Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1668 closed defect (fixed)

Extension pages use wrong direction for right-to-left languages

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-2.6.7-for-Firefox
Module: User-Interface Keywords:
Cc: greiner, sven, trev Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5137457368530944

Description (last modified by sebastian)

Environment

Chrome, Opera, Safari and Firefox with an right-to-left language (like Arabic or Hebrew)

Observed behaviour

On the first run page the texts and layout flows from left to right.

The same with the options page, popup UI and "Block element" dialog, on Chrome Opera and Safari.

Expected behaviour

Text and layout must flow from right to left in Arabic and Hebrew.

Change History (11)

comment:1 Changed 5 years ago by sebastian

  • Cc trev added

comment:2 Changed 5 years ago by sebastian

  • Summary changed from Layout direction must be right-to-left or Arabic and Hebrew to Layout direction must be right-to-left in Arabic and Hebrew

comment:3 Changed 5 years ago by sebastian

  • Owner set to sebastian

comment:4 Changed 5 years ago by sebastian

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:6 Changed 5 years ago by sebastian

  • Blocked By 1678 added

comment:7 Changed 5 years ago by sebastian

  • Description modified (diff)
  • Summary changed from Layout direction must be right-to-left in Arabic and Hebrew to Extension pages use wrong direction for right-to-left languages

comment:8 Changed 5 years ago by sebastian

  • Blocked By 1678 removed
  • Resolution set to fixed
  • Status changed from reviewing to closed
Last edited 5 years ago by sebastian (previous) (diff)

comment:9 Changed 5 years ago by ItielMaN

Thanks sebastian, the new RTL UI is almost perfect, you only forgot RTLing the tabs on the options page..
They should be also RTL'd.

comment:10 Changed 5 years ago by sebastian

Thanks for pointing this out. This should be considered for the new options page (#1524).

comment:11 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
Note: See TracTickets for help on using tickets.