Opened 5 years ago

Closed 5 years ago

#1671 closed change (fixed)

Remove "Hide placeholders" option from the UI on Chrome/Opera/Safari

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: trev, greiner Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6201561285918720

Description

Background

The effect of that option is limitted and confusing, since it doesn't have any effect on element hiding. Also we assume only very few users using this option. And correctly considering that option makes things more complicated in some cases (e.g. with the "Block Element" functionality).

But for now, we only want to remove that option from the UI. So if users complain about that change, they can disable element collapsing again on the console.

What to change

Remove the "Hide placeholders" option from the options page and reset the option, always collapsing blocked elements. However, keep the functionlity in there for now.

Change History (3)

comment:1 Changed 5 years ago by sebastian

See #1670, for respective Firefox issue.

comment:2 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.