Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#1681 closed change (fixed)

Incorrect usage of BString

Reported by: sergz Assignee: sergz
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.4
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4859310991474688/

Description

Background

In the file PluginClass.cpp the line BSTR urlToNavigate = BString(UserSettingsFileUrl()); is incorrect. urlToNavigate points to already released memory.

What to change

Use ATL::CComBSTR and we can get rid of BString.

Change History (5)

comment:1 Changed 5 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sergz

  • Owner set to sergz

comment:3 Changed 4 years ago by oleksandr

  • Platform changed from Unknown to Internet Explorer
  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed 4 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
Note: See TracTickets for help on using tickets.