Opened 5 years ago

Closed 5 years ago

#1682 closed defect (fixed)

Paypal contribution page tries to request some non-existing image

Reported by: philll Assignee: trev
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: jobp Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5749769649520640

Description (last modified by philll)

How to reproduce

  1. Go to https://adblockplus.org/en/donate
  2. Check some donation amount's radio button
  3. Click the donate button

Observed behaviour

The PayPal page opened tries to request the image https://eyeo.com/images/paypal_header.png which doesn't exist under this path.

Expected behaviour

The ABP logo should be displayed instead.

Attachments (1)

paypal_header.png (41.1 KB) - added by trev 5 years ago.
Old PayPal header

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by philll

  • Description modified (diff)

I couldn't actually find where the image currently requested is defined, but handing over an image URL with some image_url or cpp_header_image parameter does the trick here, see also their "paypal documentation. We need to host some decently sized ABP logo first.

comment:2 Changed 5 years ago by trev

It's quite certainly set in the PayPal account (https://www.paypalobjects.com/webstatic/en_US/developer/docs/pdf/pp_merchantsetupadministrationguide.pdf, "Co-Branding the PayPal Checkout Pages" section). For Job's account only "Eyeo GmbH" appears as header, when using Till's account we get that image however. Overriding it is certainly a good idea, only question: what image should we use? Alternatively we could remove these settings from the account and just have a text header.

I'll attach paypal_header.png from the previous reincarnation of eyeo.com.

Changed 5 years ago by trev

Old PayPal header

comment:3 Changed 5 years ago by philll

Well, that one looks certainly good. We can reuse it imo.

comment:4 Changed 5 years ago by trev

  • Owner set to trev
  • Priority changed from Unknown to P3
  • Ready set

It's actually pretty ugly, at least unless we also change the background color. But let's try this...

comment:5 Changed 5 years ago by trev

I realized that passing in page_style: "paypal" makes PayPal forget anything defined in the account. Also, we should probably pass in cpp_payflow_color: "F6F4EF" to make sure that header image doesn't look out of place on a white background.

comment:6 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.