Opened 5 years ago

Closed 2 years ago

Last modified 2 years ago

#1688 closed defect (worksforme)

When a filter is added, it gets added to whitelisted domains without display.

Reported by: passbrains Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords: options-page-2017
Cc: greiner, sven, saroyanm Blocked By: #2376
Blocking: Platform: Chrome
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-73

Environment

Windows + 8 64bit + Chrome + English
ABP version 1.8.5.1221

How to reproduce

  1. Add the 'ABP' plugin to the Chrome browser.
  2. Press ABP icon and select Options.
  3. Select 'Add your own filters' and add filter @@||timesofindia.indiatimes.com$document .
  4. There is no display. Press 'Whitelisted domains' and see that 'timesofindia.indiatimes.com' exists. 

Whitelisted domains tab can be displayed or a message that 'domain is added to Whitelisted domains' shall be given.

Observed behaviour

Whitelisted domains tab is not displayed. There is no message to user.

Expected behaviour

Whitelisted domains tab can be displayed instead of staying in 'Add your own filters' tab display.

Attachments (1)

3766_1411125458_addFilter.mp4 (507.8 KB) - added by passbrains 5 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by passbrains

comment:1 Changed 5 years ago by passbrains

1 - 19 Sep 2014 09:58:59 posted by Timo Scherf
Hello Rajeswari,
could you please upload significant screenshots.
Thanks for your cooperation.
Greetings from passbrains

2 - 19 Sep 2014 11:17:56 posted by Rajeswari Vemuri
Attached video.

comment:2 Changed 5 years ago by sebastian

  • Cc greiner sven added
  • Component changed from Unknown to User-Interface
  • Description modified (diff)

comment:3 Changed 5 years ago by greiner

Also see #1749

comment:4 Changed 5 years ago by sergz

In addition to #1749 although not sure whether it should be in this ticket, on the whitelisted tab the filter is not clear, for example for @@||163.com^$document it shows merely 163.com.

comment:5 Changed 5 years ago by greiner

  • Blocking 1526 added
  • Description modified (diff)

comment:6 Changed 4 years ago by saroyanm

  • Blocking 1524 added; 1526 removed

Changed blocking ticket so I can close #1526.

comment:7 Changed 4 years ago by saroyanm

  • Blocked By 2376 added
  • Blocking 1524 removed
  • Cc saroyanm added

This should be covered after custom filter implementation is done, or maybe that would be already covered in #2376.

comment:8 Changed 2 years ago by saroyanm

  • Keywords works-in-new-options-page added
  • Resolution set to worksforme
  • Status changed from new to closed
  • Tester set to Unknown

This should be fixed when we launch the new options page, which most probably will be included in the next release:

We currently showing a "example.com" has been whitelisted. (#5169) in the new Options Page in current scenario, though we still have an issue for the filter list mentioned here

comment:9 Changed 2 years ago by saroyanm

  • Keywords options-page-2017 added; works-in-new-options-page removed
Note: See TracTickets for help on using tickets.