Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1699 closed change (fixed)

Missed using of url to detect request type

Reported by: sergz Assignee: sergz
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.4
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr Blocked By:
Blocking: #1115 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5171077567217664/

Description

Background

In src\plugin\PluginWbPassThrough.cpp we call GetContentTypeFromMimeType(ATL::CString(acceptHeader.c_str())); but in IE8 it's very often */*, so the type is other.

What to change

Call GetContentType(ATL::CString(acceptHeader.c_str()), m_boundDomain, ToCString(src));.

Change History (5)

comment:1 Changed 5 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by oleksandr

  • Platform changed from Unknown to Internet Explorer
  • Ready set

comment:3 Changed 5 years ago by oleksandr

  • Priority changed from Unknown to P3

comment:4 Changed 5 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 5 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
Note: See TracTickets for help on using tickets.