Opened 5 years ago

Last modified 5 years ago

#16 closed change

[libadblockplus integration cleanup] Deal with JNI better — at Version 8

Reported by: fhd Assignee: rjeschke
Priority: P3 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: #7 Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6606493159784448/
http://codereview.adblockplus.org/5697499218051072/
http://codereview.adblockplus.org/5698450620416000/

Description (last modified by fhd)

Background

See #7.

What to change

We have multiple options. One way would be to create RAII wrappers for JNI objects (as discussed here: http://codereview.adblockplus.org/11172036/#msg3). Another option is to create thin JNI wrappers for the libadblockplus API and move most of the logic to Java.

We decided to go with the latter.

Change History (8)

comment:1 Changed 5 years ago by philll

  • Blocking 7 added

comment:2 Changed 5 years ago by philll

  • Keywords libadblockplus integration cleanup removed

comment:3 Changed 5 years ago by trev

  • Component changed from Unknown to ABP-Android

comment:4 Changed 5 years ago by philll

  • Owner set to rjeschke
  • Status changed from new to assigned

comment:5 Changed 5 years ago by fhd

  • Priority changed from Unknown to P3

comment:6 Changed 5 years ago by fhd

  • Description modified (diff)
  • Priority changed from P3 to Unknown
  • Summary changed from [libadblockplus integration cleanup] Create RAII wrappers for JNI objects to [libadblockplus integration cleanup] Deal with JNI better

comment:7 Changed 5 years ago by fhd

  • Reporter changed from philll to fhd

comment:8 Changed 5 years ago by fhd

  • Description modified (diff)
Note: See TracTickets for help on using tickets.