Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#1704 closed change (fixed)

Don't configure content scripts with "match_about_blank" on Chrome

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: #1703 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4896167448018944

Description (last modified by sebastian)

Background

With comment:5:ticket:581 we began using the match_about_blank option for content scripts.

That option were introduced in Chrome 37. However, on Chrome 37-40 content scripts using this option don't run at document_start on javascript: URLs (Chrome Bug 416907). Moreover, the load event isn't dispatched for content scripts running on about:blank or javascript: URLs (Chrome bug 442107).

Therefore we cannot use the match_about_blank for now, and have to apply element hiding and collapsing from the parent document of those frames again, as done by #1703.

What to change

Remove the match_about_blank option for content scripts on Chrome.

Change History (4)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Description modified (diff)

comment:3 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 4 years ago by sebastian

  • Description modified (diff)
Note: See TracTickets for help on using tickets.