#1706 closed change (fixed)
Integrate first-run page changes in Firefox
Reported by: | trev | Assignee: | trev |
---|---|---|---|
Priority: | P1 | Milestone: | Adblock-Plus-2.6.7-for-Firefox |
Module: | Adblock-Plus-for-Firefox | Keywords: | |
Cc: | Blocked By: | #1663, #1707 | |
Blocking: | Platform: | Firefox | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description (last modified by trev)
Background
#1663 moves the first-run page into the adblockplusui repository and makes sure asynchronous messaging is being used. We need to start using this implementations in Firefox.
What to change
- Add adblockplusui repository as a dependency.
- Make sure all the necessary files as well as localization data are imported (buildtools update required for the latter).
- Implement the required parts of the abstraction layer for the first-run page to work in Firefox.
Hints for testers
The entire functionality of the first-run page needs to be tested again.
Change History (4)
comment:1 Changed 5 years ago by trev
- Blocked By 1707 added
comment:2 Changed 5 years ago by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed 5 years ago by trev
- Description modified (diff)
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed 5 years ago by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/adblockplus/rev/5e20171b73da