Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1708 closed change (fixed)

Integrate first-run page changes in Chrome/Opera/Safari

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-1.8.10-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By: #1663, #1709
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6528746257383424/

Description (last modified by trev)

Background

#1663 moves the first-run page into the adblockplusui repository and makes sure asynchronous messaging is being used. We need to start using this implementations in Chrome/Opera/Safari.

What to change

  • Add adblockplusui repository as a dependency.
  • Make sure all the necessary files as well as localization data are imported (buildtools update required for the latter).
  • Implement the required message responders in the adblockpluschrome respository.

Hints for testers

The first-run page needs to be tested completely. The change in #1655 will also be "imported" here, it should have no visible impact (i.e. the extension should stay installable).

Change History (7)

comment:1 Changed 5 years ago by trev

  • Blocked By 1709 added

comment:2 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by trev

  • Description modified (diff)

comment:4 Changed 5 years ago by sebastian

This will also fix #1741.

comment:5 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-1.8.10-for-Chrome-Opera-Safari

comment:7 Changed 5 years ago by sebastian

  • Owner set to trev
Note: See TracTickets for help on using tickets.