Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#171 closed defect (fixed)

[trac] setting issues to "codereview" status is possible for all users

Reported by: philll Assignee: philll
Priority: Unknown Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/5710953018556416/

Description

Environment

Trac instance at https://issues.adblockplus.org

How to reproduce

  1. Log in to the ABP Trac instance as normal user
  2. Open any existing Ticket, which does not have the depricated status "accepted"
  3. Expand the "Modify Ticket" section

Observed behaviour

The "codereview" radio button is displayed.

Expected behaviour

Except the already checked "leave as ..." option, no additional radio buttons should be available.

Change History (7)

comment:1 Changed 6 years ago by philll

.

comment:2 Changed 6 years ago by philll

  • Component changed from Unknown to Infrastructure

comment:3 Changed 6 years ago by philll

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 6 years ago by philll

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 6 years ago by philll

  • Resolution fixed deleted
  • Status changed from closed to reopened

Setting the codereview status is still possible for users without the TICKET_MODIFY permission.

comment:6 Changed 6 years ago by philll

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:7 Changed 6 years ago by philll

  • Verified working set
Note: See TracTickets for help on using tickets.