Opened 6 years ago

Closed 4 years ago

#1718 closed change (duplicate)

Limit workaround for Chrome bug breaking Flash videos to Chrome 38-40

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Platform Keywords: externaldependency
Cc: trev Blocked By:
Blocking: Platform: Unknown
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



Chrome 38-40 mistakenly identified requests loading <object> elements like Flash, and requests initiated by those third-party plugins, with the type other instead object.

We worked around that issue, by pretending that every request of the type other is actually of the type object on Chrome 38 and higher as implemented by #1372 and #1593. However, the Chrome bug responsible got recently fixed, and that workaround isn't needed anymore on Chrome 41 and above.

What to change

Limit workaround for Chrome bug 410382 to the affected versions (i.e. Chrome 38-40), relying again on the webRequest API to distinguish the request types other and object.

Change History (4)

comment:1 Changed 6 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 6 years ago by sebastian

  • Cc trev added
  • Keywords externaldependency added
  • Ready unset

The fix for has recently been reverted. :(

comment:3 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)

comment:4 Changed 4 years ago by sebastian

  • Resolution set to duplicate
  • Status changed from reviewing to closed
  • Tester set to Unknown

Chrome bug 410382 got finally fixed in Chrome 49. The workaround has been adapted with #3453.

Note: See TracTickets for help on using tickets.