Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#172 closed defect (fixed)

Don't make our icons web accessible

Reported by: trev Assignee: saroyanm
Priority: P1 Milestone: Adblock-Plus-1.8-for-Chrome-Opera-Safari
Module: Platform Keywords: chrome
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5677191404716032/

Description

http://codereview.adblockplus.org/6098518317989888/ made icons/abp-128.png web accessible. This is bad because it makes Adblock Plus detectable in a trivial way. What's worse, it doesn't look like this is necessary - the icon actually used by notification.html is icons/abp-48.png, that's not the same icon.

This change needs to be reverted. If it turns out that a web-accessible icon is really needed, the extension should simply convert the icon into a data: URL.

Change History (6)

comment:1 in reply to: ↑ description Changed 5 years ago by greiner

Replying to trev:

http://codereview.adblockplus.org/6098518317989888/ made icons/abp-128.png web accessible. This is bad because it makes Adblock Plus detectable in a trivial way. What's worse, it doesn't look like this is necessary - the icon actually used by notification.html is icons/abp-48.png, that's not the same icon.

icons/abp-128.png is used for webkitNotifications.createNotification and for chrome.notifications.create (see corresponding review).

That said, I still agree regarding the conversion to a data: URL.

comment:2 Changed 5 years ago by saroyanm

  • Status changed from new to reviewing

comment:4 Changed 5 years ago by trev

  • Review URL(s) modified (diff)

comment:5 Changed 5 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See TracTickets for help on using tickets.