Opened on 12/19/2014 at 04:25:53 PM

Closed on 12/19/2014 at 04:29:09 PM

#1722 closed change (fixed)

Update adblockplus dependency to 816bc28239cd

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):



We have to update the "adblockplus" submodule for the 1.8.9 release, most importantly to fix an issue with right-to-left languages (#1668), but also pulling in some other changes:

Extension pages use wrong direction for right-to-left languages
Remove "Hide placeholders" option from the UI on Firefox
Use String.trim() to strip leading/trailing whitespaces

What to change

Update the "adblockplus" submodule to revision 816bc28239cd.

Hints for testers

  • Make sure that text and layout is aligned in the correct direction, in particular for right-to-left languages (i.e. Arabic, Hebrew and Persian). This affects the first run page, options page, icon popup and "Block Element" dialog. Also make sure that this change (#1668) didn't introduced any regressions, breaking the layout there.
  • The code normalizing filters (e.g. when adding own filters) is affected by #1675 and should be tested.

Attachments (0)

Change History (2)

comment:1 Changed on 12/19/2014 at 04:26:28 PM by sebastian

  • Component changed from Unknown to Platform
  • Owner set to sebastian
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 12/19/2014 at 04:29:09 PM by sebastian

  • Milestone set to Adblock-Plus-1.8.9-for-Chrome-Opera-Safari
  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Note: See TracTickets for help on using tickets.