Changes between Version 25 and Version 26 of Ticket #1727


Ignore:
Timestamp:
08/10/2016 01:14:24 PM (15 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1727 – Description

    v25 v26  
    3535It's important to test as many websites that use WebSockets properly as possible, wrapping WebSocket like this could well cause problems. (For more examples see the discussions linked in the References section above.) 
    3636 
    37 Finally we refactored some of the code added with issue #1677 whilst making these changes. So it's also important to make sure that code to protect our ElemHide stylesheets still works. In case the US version of Yahoo no longer uses this circumvention technique here are the steps I took to test the feature. (All in the console for a webpage.) 
     37We refactored some of the code added with issue #1677 whilst making these changes. So it's also important to make sure that code to protect our ElemHide stylesheets still works. In case the US version of Yahoo no longer uses this circumvention technique here are the steps I took to test the feature. (All in the console for a webpage.) 
    3838 
    39391. Find our stylesheet: `var sheet = document.documentElement.shadowRoot.styleSheets[0];` (Note: On some browsers you will need to remove the ".shadowRoot", also note that 0 might be the wrong index. You'll have to experiment to figure out the correct number.) 
     
    43435. Now check no rules were removed, by checking the number of rules again: `sheet.rules.length;` 
    44446. Finally ensure our sheet can't be disabled: `sheet.disabled = true; sheet.disabled;` (Should display false.) 
     45 
     46Finally we also refactored some code relating to YouTube adblocking for older versions of Safari which used Flash. Please test that YouTube adverts do not play when using an old version of Safari, to make sure a regression like #4141 has not resurfaced. (Take a look at that issue for some more testing approaches.)