Opened 5 years ago

Closed 5 years ago

#1739 closed change (fixed)

Respect MessageSender.frameId on Chrome 41+

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.10-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/4890865847762944

Description

Background

Currently we iterate over all previously seen frames comparing the URL, to figure out the sender's frame in chrome.runtime.onMessage. This approach is inefficient and error-prone. But before Chrome 41 this was the best we could do. However, Chrome 41 introduces MessageSender.frameId, making that hack obsolete.

What to change

Rely on MessageSender.frameId if available to identify the sender's frame in chrome.runtime.onMessage.

Change History (2)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.