Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#174 closed change (fixed)

Port anti-adblock notification to Chrome, Opera and Safari

Reported by: greiner Assignee: greiner
Priority: P1 Milestone: Adblock-Plus-1.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: fhd, trev Blocked By: #196
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5749582424178688/
http://codereview.adblockplus.org/6020195227271168/

Description (last modified by greiner)

Background

We introduced the anti-adblock notification in Firefox for showing a new type of notification to users visiting websites which show anti-adblock warning messages.

What to change

Reuse the core code and implement the new "question"-type notification for Chrome, Opera and Safari.

Change History (3)

comment:1 Changed 6 years ago by greiner

  • Description modified (diff)
  • Summary changed from Port over anti-adblock notification to Port anti-adblock notification to Chrome, Opera and Safari

comment:2 Changed 6 years ago by trev

  • Cc trev added
  • Resolution set to fixed
  • Status changed from new to closed

Seeing that both changes already landed, I think that this can be resolved as fixed.

https://hg.adblockplus.org/adblockplus/rev/41296853991b
https://hg.adblockplus.org/adblockpluschrome/rev/fa4e83869b3c

comment:3 Changed 6 years ago by trev

  • Blocked By 196 added
Note: See TracTickets for help on using tickets.