Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1742 closed change (fixed)

Use "highlighted" property instead deprecated "selected" property when calling chrome.tabs.update()

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.8.10-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By: #1820
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/4593389433520128

Description

Background

In order to focus an existing tab on Chrome we call chrome.tabs.update(id, {selected: true}). However, the selected property is deprecated, and highlighted should be used instead.

What to change

Adapt all chrome.tabs.update() calls to use the highlighted property instead the selected property.

Change History (3)

comment:1 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 5 years ago by trev

  • Blocked By 1820 added
Note: See TracTickets for help on using tickets.