Opened 5 years ago

Closed 5 years ago

#1755 closed defect (fixed)

"Block element" still injects overlays with wrong z-index

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.10-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/5852223410012160

Description

Environment

Chrome, Opera, Safari

How to reproduce

  1. Go to google.com
  2. Sign in
  3. Click ABP icon
  4. Choose "Block element"
  5. Hover and/or click user avatar in the upper right corner

Observed behaviour

The image isn't highlighted.

Expected behaviour

The selected element should be highlighted.

Change History (4)

comment:1 Changed 5 years ago by sebastian

Initially we injected those overlays always with z-index: 99999. Then we realized that some overlays cover other elements, that have a higher z-index than the element the overlay were created for. So we attempted to use the same z-index for the overlay as in effect for the element it was created for (#1607). However, the approach implemented there, don't consider the case where the z-index isn't defined on the immediate offset parent, but on an other offset ancestor.

comment:2 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)

comment:4 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.