Opened on 01/05/2015 at 04:46:57 PM

Closed on 01/13/2015 at 02:22:02 PM

#1755 closed defect (fixed)

"Block element" still injects overlays with wrong z-index

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.10-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):



Chrome, Opera, Safari

How to reproduce

  1. Go to
  2. Sign in
  3. Click ABP icon
  4. Choose "Block element"
  5. Hover and/or click user avatar in the upper right corner

Observed behaviour

The image isn't highlighted.

Expected behaviour

The selected element should be highlighted.

Attachments (0)

Change History (4)

comment:1 Changed on 01/05/2015 at 04:47:36 PM by sebastian

Initially we injected those overlays always with z-index: 99999. Then we realized that some overlays cover other elements, that have a higher z-index than the element the overlay were created for. So we attempted to use the same z-index for the overlay as in effect for the element it was created for (#1607). However, the approach implemented there, don't consider the case where the z-index isn't defined on the immediate offset parent, but on an other offset ancestor.

comment:2 Changed on 01/05/2015 at 04:51:23 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 01/06/2015 at 10:42:55 AM by sebastian

  • Review URL(s) modified (diff)

comment:4 Changed on 01/13/2015 at 02:22:02 PM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Note: See TracTickets for help on using tickets.