Opened 5 years ago

Closed 5 years ago

#1756 closed change (rejected)

|| should not require to have a schema in the URL

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: arthur, sebastian Blocked By:
Blocking: Platform: Unknown
Ready: no Confidential: no
Tester: Verified working:
Review URL(s):

Description

Background

Given the filter rule @@||163.com^$document the following URLs are whitelisted http://163.com and any-schema://any-subdomain.163.com but 163.com as well as www.163.com are not whitelisted.
If we allow any schema why is it required to have it?

What to change

Add support for the input URL without schema.
As well as it should be stated in the documentation.

Change History (3)

comment:1 Changed 5 years ago by arthur

  • Cc arthur added

comment:2 Changed 5 years ago by sebastian

  • Cc sebastian added

defaultMatcher.matchesAny() expects an absolute URL as first argument, which always has a schema. I think if you pass a domain instead, this is a bug in the calling code, and the behavior is undefined.

Last edited 5 years ago by sebastian (previous) (diff)

comment:3 Changed 5 years ago by sebastian

  • Resolution set to rejected
  • Status changed from new to closed

As discussed with sergz it's indeed a bug on Maxthon's end.

Note: See TracTickets for help on using tickets.