Opened 5 years ago

Closed 2 years ago

#1764 closed change (rejected)

Add API to indicate the filters have been loaded

Reported by: her34 Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords: goodfirstbug
Cc: trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by trev)

Background

Adblock Plus provides an API for external extensions to use. However, the external extensions have no way of knowing whether ABP is actually ready - the component will be available before the filters load.

What to change

There are two possible ways to solve this. One would be an additional API, e.g. a boolean IAdblockPlus.filtersLoaded plus a way to add listeners that will be notified when Adblock Plus filters load.

However, given that IAdblockPlus is very much about filters, it should be preferable to only register the corresponding component once the filters are actually available. These would remove the scenario where the API is available but cannot really be used.

Change History (11)

comment:1 Changed 5 years ago by trev

  • Cc trev added
  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Description modified (diff)
  • Platform changed from Unknown to Firefox/Firefox Mobile
  • Priority changed from Unknown to P4
  • Ready set
  • Summary changed from Request: api to report ABP is fully loaded to Add API to indicate the filters have been loaded
  • Type changed from defect to change

comment:2 Changed 5 years ago by trev

  • Keywords goodfirstbug added

comment:3 Changed 5 years ago by Mailkov

Hi , I would like to work on this change

comment:4 Changed 5 years ago by trev

  • Owner set to Mailkov

Sure. Let me know if you have questions.

comment:6 Changed 5 years ago by trev

  • Owner Mailkov deleted

Unassigning - no progress, maybe somebody else wants to work on this.

comment:7 Changed 5 years ago by Mailkov

You could contact me before unsubscribe.

comment:8 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

comment:9 in reply to: ↑ 5 Changed 4 years ago by erikvold

  • Tester set to Unknown
  • Verified working unset

Replying to Mailkov:

Pull request:https://github.com/adblockplus/adblockplus/pull/9

This appears to be a dead link, did something happen to it?

comment:10 Changed 4 years ago by trev

Yes, our hg to git sync broke and we couldn't find any way to fix this other than resetting the repository :-(

comment:11 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.