Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#1765 closed change (fixed)

Align Firefox messaging implementation with Safari

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.6.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/5772325207146496

Description (last modified by trev)

Background

Abstraction layer for messaging was introduced to Firefox in #1706. The implementation was very similar to Safari's, yet some of the changes introduced in #1724 made the two implementation diverge (with good reason).

What to change

Implement the relevant changes in Firefox as well:

  • If there is no response, don't set the payload property of the message instead of sending responseSent: false.
  • Use a local sent variable instead of the this._responseSent property to save whether the message was handled.
  • Return a list with results from all handlers in EventTarget._dispatch instead of making assumptions about the nature of the result.

Hints for testers

This change again affects all functionality of the first-run page.

Change History (4)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 5 years ago by trev

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Firefox-next

comment:4 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.