Opened 5 years ago

Closed 5 years ago

#1766 closed change (fixed)

Output directory for Safari development environment should be devenv/adblockplussafari.safariextension

Reported by: trev Assignee: sebastian
Priority: P4 Milestone:
Module: Automation Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/4812956214755328

Description (last modified by sebastian)

Background

Currently the build.py -t safari devenv puts the files directly into the devenv folder. Safari won't load extensions from it however, it can only load unpacked extensions from folders with the .safariextension file extension.

What to change

Keep the same file structure when running build.py -t safari devenv as when generating builds, creating devenv/adblockplussafari.safariextension and putting the content of the extension there.

Change History (4)

comment:1 Changed 5 years ago by sebastian

  • Keywords goodfirstbug added
  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed 5 years ago by sebastian

  • Cc sebastian removed
  • Description modified (diff)
  • Owner set to sebastian
  • Summary changed from Output directory for Safari development environment should be devenv.safariextension to Output directory for Safari development environment should be devenv/adblockplussafari.safariextension

comment:3 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.