Opened 5 years ago

Closed 5 years ago

#1768 closed defect (fixed)

Asynchronous responses aren't dispatched on Chrome / "Block element" broken

Reported by: mapx Assignee: sebastian
Priority: P2 Milestone: Adblock-Plus-1.8.10-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: trev Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/5162273421131776

Description

Environment

chrome 39, 40
ABP 1.8.9.1300

How to reproduce

-visit a page
-try the "block element" feature (or right click on image) ==> the "add filters" window is empty

Change History (6)

comment:1 Changed 5 years ago by fhd

Cannot reproduce this with Chrome 39 and ABP 1.8.9.1300 (or 1.8.9 for that matter).

I've used it on the infographic on https://adblockplus.org/en/about, among other things. The add filter window appears properly, and the filter is also added properly.

Can you point to a specific site/element where you can reproduce this?

comment:2 Changed 5 years ago by mapx

https://www.google.co.uk/
on the google logo, it should create something like
google.co.uk###lga

I tested again on a chrome portable 39, removing 1300, reinstalling again ==> the same behaviour

1.8.9 (stable) works fine

Last edited 5 years ago by mapx (previous) (diff)

comment:3 Changed 5 years ago by philll

I don't get any filter suggestions for any elements on web.de, neither adblockplus.org

comment:4 Changed 5 years ago by sebastian

  • Cc sebastian removed
  • Owner set to sebastian
  • Priority changed from Unknown to P2
  • Ready set
  • Summary changed from ABP 1.8.9.1300 ==> "block element" broken to Asynchronous responses aren't dispatched on Chrome / "Block element" broken

This is a regression introduced by the latest change.

comment:5 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.