Opened 5 years ago

Closed 5 years ago

#1772 closed change (fixed)

[JSHydra] Convert const to var for Chrome

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: #145 Platform: Chrome
Ready: no Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/4935066966818816/

Description

Background

#145 introduced a bunch of module using "use strict". Testing these modules fails in Chrome right now because const variables are left unchanged - yet Chrome no longer allows them in "strict" JavaScript.

What to change

Convert const variables to regular ones using in JSHydra.

Change History (2)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.