Opened 5 years ago

Closed 5 years ago

#1777 closed defect (fixed)

ensure_dependencies.py fails to detect unknown Git revisions

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: #1588 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/4814432072892416/

Description

How to reproduce

  1. Clone an older dependency state into a Git repository.
  2. Update dependency to point to the latest repository.
  3. Run ensure_dependencies.py

Observed behaviour

ensure_dependencies.py attempts to update the dependency without fetching new data and fails. This is a bug in Git.get_revision_id(), the current implementation will happily declare any revision ID as existing.

Expected behaviour

ensure_dependencies.py should fetch new data from the remote repository first and only update after that.

Change History (2)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.