Opened 5 years ago

Closed 5 years ago

#1778 closed change (fixed)

Generate proper build numbers when working with Git repositories

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

https://github.com/adblockplus/buildtools/pull/3
http://codereview.adblockplus.org/6562202978877440/

Description

Background

Currently, the way we generate build numbers is Mercurial-specific. When no Mercurial repository is present (e.g. for Git repositories) the build number will always be 0 and a misleading error message "abort: there is no Mercurial repository here (.hg not found)" will appear.

What to change

Recognize repository type and don't try running Mercurial commands on directories that aren't Mercurial repositories. Calculate a numerical build number for Git repositories as well.

Change History (2)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.