Opened 5 years ago

Closed 5 years ago

#1784 closed change (fixed)

"Block popup for this website" is added to the ABP UI, but is browser functionality

Reported by: jobp Assignee: jobp
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: sven Blocked By:
Blocking: Platform: Maxthon
Ready: no Confidential: no
Tester: Verified working:
Review URL(s):

Description (last modified by jobp)

Environment

ABP for Maxthon has a "Block popup for this website" feature for both the Chinese and International version. This calls the "window.open" function, and is not Adblock Plus functionality.

Also, when the function is called, it loads empty elements in the UI - see attachment for more information.

How to reproduce

  1. Launch Maxthon beta 4.4.4.800
  2. Go to a random website (e.g. cnn.com)
  3. Click on ABP icon, and see the "Block popup for this website" element in the UI

Solution

This feature should be designed/implemented in such a way that it is clear that it is a browser (or Maxthon) feature.

Attachments (1)

maxthon.popup.png (40.8 KB) - added by jobp 5 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by jobp

  • Description modified (diff)

comment:2 Changed 5 years ago by jobp

  • Description modified (diff)

Changed 5 years ago by jobp

comment:3 Changed 5 years ago by jobp

  • Description modified (diff)

comment:4 Changed 5 years ago by jobp

  • Summary changed from "Block popup for this website" feature to "Block popup for this website" is added to the ABP UI, but is browser functionality

comment:5 Changed 5 years ago by jobp

  • Type changed from defect to change

comment:6 Changed 5 years ago by jobp

  • Description modified (diff)

comment:7 Changed 5 years ago by jobp

  • Cc sven added
  • Description modified (diff)

comment:8 Changed 5 years ago by jobp

Almost fixed, we have to agree on a UI. No problems expected there. We should be able to communicate the suggestions on Monday.

comment:9 Changed 5 years ago by jobp

  • Owner set to jobp

comment:10 Changed 5 years ago by jobp

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.