Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#179 closed change (fixed)

Make sure webRequest listener never throws exceptions

Reported by: trev Assignee:
Priority: P1 Milestone: Adblock-Plus-1.8-for-Chrome-Opera-Safari
Module: Platform Keywords: chrome
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5328346325975040/

Description

Background

http://code.google.com/p/chromium/issues/detail?id=349139 introduced a change in webRequest behavior with the effect that an exception in the webRequest listener cancels the request. For us this means that our listener should never throw an exception.

What to change

We need to wrap the webRequest listener in a try..catch block and only log exceptions. The default should be to allow the request, not to block it.

Change History (5)

comment:1 Changed 6 years ago by trev

  • Keywords chrome added
  • Ready set

comment:2 Changed 6 years ago by sebastian

  • Status changed from new to reviewing

comment:3 Changed 6 years ago by trev

  • Review URL(s) modified (diff)

comment:4 Changed 6 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 6 years ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See TracTickets for help on using tickets.