Opened 3 years ago

Closed 2 years ago

Last modified 17 months ago

#1793 closed change (fixed)

Check whether the frame is whitelisted before injecting CSS

Reported by: sergz Assignee: sergz
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr, eric@… Blocked By: #1794, #1795, #3412
Blocking: #119 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Rraceanu Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/5447868882092032/

Description

Background

Before injecting CSS we should test whether we need to inject it or not.

What to change

Currently FilterEngine::Matches already accepts frame hierarchy but the implementation does not look completely correct. So, to be consistent with other platforms let's implement the handling of frame hierarchy manually as it's done for Chrome https://hg.adblockplus.org/adblockpluschrome/file/9b341ec66249/lib/whitelisting.js#l36. I guess later we can move it into libadblockplus.

Change History (10)

comment:1 Changed 3 years ago by sergz

  • Blocked By 1794 added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by sergz

  • Blocked By 1795 added

comment:3 Changed 3 years ago by sergz

  • Blocking 119 added

comment:4 Changed 3 years ago by oleksandr

  • Platform changed from Unknown to Internet Explorer
  • Priority changed from Unknown to P3
  • Ready set

comment:5 Changed 3 years ago by sergz

  • Summary changed from Check whether the frame is whitellisted before injecting CSS to Check whether the frame is whitelisted before injecting CSS
  • Tester set to Unknown
  • Verified working unset

comment:6 Changed 2 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 2 years ago by oleksandr

  • Blocked By 3412 added

comment:8 Changed 19 months ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next

comment:9 Changed 19 months ago by rraceanu

  • Tester changed from Unknown to Rraceanu

comment:10 Changed 17 months ago by rraceanu

  • Verified working set

Change successfully implemented, was verified on IE 10 Windows 8 and 8.1, IE 11 Windows 10 pro and home, ABP 1.5.856

Note: See TracTickets for help on using tickets.