Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#1813 closed change (fixed)

Implement ext.showOptions() in Firefox

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.6.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By: #1814
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/5817039037923328/

Description

Background

This is a spinoff from #1663: the first-run page currently has to call different code to open options depending on whether it is running in Firefox or Chrome. It should always call ext.showOptions() instead.

What to change

Implement ext.showOptions() in Firefox.

Change History (5)

comment:1 Changed 5 years ago by trev

  • Blocked By 1814 added

comment:2 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplus/rev/90d89f9b4f11

comment:4 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:5 Changed 5 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.