Opened 5 years ago

Closed 5 years ago

#1814 closed change (fixed)

Use ext.showOptions() on the first-run page

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #1813 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/6141186662203392/

Description

Background

This is a spinoff from #1663: the first-run page currently has to call different code to open options depending on whether it is running in Firefox or Chrome. It should always call ext.showOptions() instead.

What to change

Once #1813 is fixed, simply call ext.showOptions() to open options.

Change History (3)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by trev

Pushed: https://hg.adblockplus.org/adblockplusui/rev/eb8a33f444e8

Leaving open, waiting for #1813 to land as well.

comment:3 Changed 5 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.