Opened 5 years ago

Closed 5 years ago

#1819 closed change (fixed)

Update dependency on adblockplusui in adblockpluschrome and remove unnecessary code

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-1.8.11-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/4918989293617152/

Description

Background

This change will import #1814 and allow some cleanup.

What to change

In addition to removing the dependency, the global openOptions() function can be removed.

Hints for testers

The link to disable acceptable ads on the first-run page should still work after this change.

Change History (3)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by trev

  • Summary changed from Update dependency on adblockplusui in adblockpluschrome to Update dependency on adblockplusui in adblockpluschrome and remove unnecessary code

comment:3 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.