Opened 5 years ago

Closed 5 years ago

#1832 closed change (fixed)

Update public suffixes list in adblockpluschrome to account for the newly available ".uk" domains

Reported by: kzar Assignee: kzar
Priority: P3 Milestone: Adblock-Plus-1.8.11-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/4652755411009536/

Description

Background

As of June 2014 it became possible to register ".uk" domains. Previously all domains ending in UK had at least one more public part.

What to change

We need to change lib/publicSuffixList.js to account for the possibility of someone registering a ".uk" domain. To do this we need to modify the value for ".uk" to 1 and add all the other possible public extensions like ".co.uk" and "org.uk" etc. (See https://publicsuffix.org/list/effective_tld_names.dat and search for "nominet" for a full list.)

Change History (3)

comment:1 Changed 5 years ago by sebastian

  • Priority changed from Unknown to P3
  • Ready set

As discussed on IRC and in the codereview, in the long-term we should automatically update lib/publicSuffixList.js based on Mozilla's Public Suffix List, with a build command. This can be addressed later, however please file an issue now, that we don't forget about it.

comment:2 Changed 5 years ago by kzar

Yep, have done that - #1834

comment:3 Changed 5 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.